Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use member initializer in the move constructor of Ptr #79

Merged
merged 1 commit into from
Feb 2, 2024
Merged

style: use member initializer in the move constructor of Ptr #79

merged 1 commit into from
Feb 2, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 2, 2024

Description

Use member initializer. Same as #77.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Use member initializer. Same as #77.

@mertcandav mertcandav self-requested a review February 2, 2024 20:10
@mertcandav mertcandav added the api About API (C++ API, not std/runtime API implementation) label Feb 2, 2024
@vil02 vil02 marked this pull request as ready for review February 2, 2024 20:14
mertcandav
mertcandav approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@mertcandav mertcandav merged commit 2f88bb7 into julelang:master Feb 2, 2024
8 checks passed
@vil02 vil02 deleted the use_member_initializer_in_ptr branch February 2, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcandav mertcandav mertcandav approved these changes

Assignees
No one assigned
Labels
api About API (C++ API, not std/runtime API implementation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @mertcandav